make distinct conversions addressable in VM #24124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24097
For
nkConv
addresses where the conversion is between 2 types that are equal between backends, treat assignments the same as assignments to the argument of the conversion. In the VM this seems to be ingenAsgn
andgenAsgnPatch
, as evidenced by the special logic fornkDerefExpr
etc.This doesn't handle ranges after #24037 because
sameBackendType
is used and notsameBackendTypeIgnoreRange
. This is so this is backportable without #24037 and another PR can be opened that implements it for ranges and adds tests as well. We can also mergesameBackendTypeIgnoreRange
withsameBackendType
since it doesn't seem like anything that uses it would be affected (only cycle checks and the VM), but then we still have to add tests.